Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added simplecov github action in unit.yml #2267

Merged
merged 10 commits into from
Sep 30, 2021
Merged

Added simplecov github action in unit.yml #2267

merged 10 commits into from
Sep 30, 2021

Conversation

RajeshPaul38
Copy link
Contributor

@RajeshPaul38 RajeshPaul38 commented Sep 28, 2021 •
edited
Loading

Signed-off-by: Rajesh Paul rajesh.paul@progress.com

Description

Added simplecov github action in unit.yml

Issues Resolved

#2220

Check List

@RajeshPaul38
Added simplecov github action in unit.yml
f2b97c2 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38 RajeshPaul38 requested review from a team as code owners September 28, 2021 14:39
@RajeshPaul38
moved last_run json to root directory of the repo
fc7241b
@RajeshPaul38
added github token for simplecov
564d520 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
change failure threshold for simplecov from 90% to 40%
03c2bfd 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
test with lesser threshold
1d539eb 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
Changed last_run file path in simplecov action configuration
2ecd774 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
removed last_run from root coverage folder
bba412b 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
disabled a unit test for checking test coverage by simplecov
e611b3d 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
set failed threshold to 90%
273bfc5 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@github-actions
Copy link

Simplecov Report

Covered Threshold
98.28% 90%

@RajeshPaul38 RajeshPaul38 linked an issue Sep 28, 2021 that may be closed by this pull request
Check unit test coverage for chef-supermarket #2220
Closed
2 tasks
This was referenced Sep 28, 2021
Closed
Closed
Closed
@RajeshPaul38
removed last_run json from commited files
31f879e 
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
@RajeshPaul38
Copy link
Contributor Author

As discussed in the scrum today I've removed the last_run json file. The simplecov integration works even without this file.
@saghoshprogress

@RajeshPaul38
Copy link
Contributor Author

Buildkite: https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/203#bef3b841-92f3-4c4b-8953-4688b4001c00

@saghoshprogress saghoshprogress merged commit 32b117f into main Sep 30, 2021
@saghoshprogress saghoshprogress deleted the rajeshpaul38/simplecov-github-action/2220 branch September 30, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajd-msys dheerajd-msys dheerajd-msys approved these changes

@saghoshprogress saghoshprogress Awaiting requested review from saghoshprogress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check unit test coverage for chef-supermarket
3 participants
@RajeshPaul38 @dheerajd-msys @saghoshprogress