-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added slack username and removed irc nickname from user profile #2172
Added slack username and removed irc nickname from user profile #2172
Conversation
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
9c52622
to
269e0ee
Compare
<%= f.text_field :irc_nickname, placeholder: 'IRC Nickname', title: 'irc nickname' %> | ||
<div class="slackusername-field"> | ||
<%= f.label :slack_username, "Slack Username" %> | ||
<%= f.text_field :slack_username, placeholder: 'Slack Userkname', title: 'slack username' %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a typo in username here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let me change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved now
Co-authored-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
7401472
to
c852e38
Compare
Any idea how we can get unit tests to run when we have DB migrations? @saghoshprogress @RajeshPaul38 |
ok @tas50 let us check on this. let's keep this PR on hold for now so that we can check if the solution works and unit test is unblocked. |
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
8d40aaa
to
78084aa
Compare
@tas50 I've added the step to do db:migrate in test env before running the specs. Now all checks are green. It's unblocked for merging. Pls take the next step. |
Description
Issues Resolved
#2150 #2173
Check List