Added slack username and removed irc nickname from user profile #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
force-pushed
the
rajeshpaul38/add-slack-and-remove-irc-from-users
branch
from
9c52622
to
269e0ee
Compare
tas50
reviewed
Aug 23, 2021
tas50
reviewed
Aug 23, 2021
| <%= f.text_field :irc_nickname, placeholder: 'IRC Nickname', title: 'irc nickname' %> | ||
| <div class="slackusername-field"> | ||
| <%= f.label :slack_username, "Slack Username" %> | ||
| <%= f.text_field :slack_username, placeholder: 'Slack Userkname', title: 'slack username' %> |
There was a problem hiding this comment.
I think there's a typo in username here
There was a problem hiding this comment.
Yeah let me change this
Co-authored-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
force-pushed
the
rajeshpaul38/add-slack-and-remove-irc-from-users
branch
from
7401472
to
c852e38
Compare
|
Feature screenshots:
|
|
Any idea how we can get unit tests to run when we have DB migrations? @saghoshprogress @RajeshPaul38 |
|
ok @tas50 let us check on this. let's keep this PR on hold for now so that we can check if the solution works and unit test is unblocked. |
Signed-off-by: Rajesh Paul <rajesh.paul@progress.com>
RajeshPaul38
force-pushed
the
rajeshpaul38/add-slack-and-remove-irc-from-users
branch
from
8d40aaa
to
78084aa
Compare
|
@tas50 I've added the step to do db:migrate in test env before running the specs. Now all checks are green. It's unblocked for merging. Pls take the next step. |
RajeshPaul38
changed the title
tas50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#2150 #2173
Check List