Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cleanup of cached gems #2132

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Fix the cleanup of cached gems #2132

merged 3 commits into from
Aug 12, 2021

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Aug 12, 2021

Make sure we expand the path first so this works

Signed-off-by: Tim Smith tsmith@chef.io

Make sure we expand the path first so this works

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners August 12, 2021 15:59
Copy link
Contributor

@RajeshPaul38 RajeshPaul38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a few suggestions.

omnibus/config/software/more-ruby-cleanup-supermarket.rb Outdated Show resolved Hide resolved
omnibus/config/software/more-ruby-cleanup-supermarket.rb Outdated Show resolved Hide resolved
tas50 and others added 2 commits August 12, 2021 09:50
Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: RajeshPaul38 <85236476+RajeshPaul38@users.noreply.github.com>
Signed-off-by: Tim Smith <tsmith@chef.io>

Co-authored-by: RajeshPaul38 <85236476+RajeshPaul38@users.noreply.github.com>
@tas50
Copy link
Contributor Author

tas50 commented Aug 12, 2021

Thanks @RajeshPaul38

@tas50 tas50 merged commit f67f44f into master Aug 12, 2021
@tas50 tas50 deleted the fix_cleanup branch August 12, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants