Upgrade rails to 6.1 and migrate nodejs to mini_racer #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
tas50
changed the title
tas50
added
the
Aspect: Security
tas50
reviewed
Aug 3, 2021
| @@ -24,7 +24,7 @@ | |||
| dependency "chef-gem" | |||
| dependency "git" | |||
| dependency "nginx" | |||
| dependency "nodejs" | |||
| # dependency "nodejs" | |||
There was a problem hiding this comment.
Suggested change
| # dependency "nodejs" |
|
@saghoshprogress can you rebase this off master. There's been a lot of changes there and there's a bunch of conflicts |
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
sure .. i will do the same |
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
tas50
reviewed
Aug 11, 2021
tas50
reviewed
Aug 11, 2021
| @@ -24,8 +24,7 @@ | |||
| dependency "chef-gem" | |||
| dependency "git" | |||
| dependency "nginx" | |||
| # dependency "nodejs" | |||
| # dependency "nodejs-binary" | |||
| dependency "nodejs-binary" | |||
There was a problem hiding this comment.
everything I have removed.
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
tas50
added
the
Expeditor: Bump Version Minor
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
reviewed
Aug 11, 2021
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Omnibus Fix for Rails 6
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List