-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rails to 6.1 and migrate nodejs to mini_racer #2093
Conversation
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
@@ -24,7 +24,7 @@ | |||
dependency "chef-gem" | |||
dependency "git" | |||
dependency "nginx" | |||
dependency "nodejs" | |||
# dependency "nodejs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# dependency "nodejs" |
@saghoshprogress can you rebase this off master. There's been a lot of changes there and there's a bunch of conflicts |
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
sure .. i will do the same |
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
@@ -24,8 +24,7 @@ | |||
dependency "chef-gem" | |||
dependency "git" | |||
dependency "nginx" | |||
# dependency "nodejs" | |||
# dependency "nodejs-binary" | |||
dependency "nodejs-binary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything I have removed.
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Description
Omnibus Fix for Rails 6
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List