-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve markdown rendering is changelogs / readmes #2081
Improve markdown rendering is changelogs / readmes #2081
Conversation
While this probably solves the immediate problem of the HTML comments, I think we want to revive the work here: #1622 to get complete GitHub compliant rendering. |
@tas50 ok, thanks i will work on that |
ed7c5cd
to
020c8ab
Compare
@tas50 I have made a commit to address missing points for supermarket to achieve Github style markdown rendering. Html-pipelines implementation is leading to many behavioural changes and opening up application to XSS vulenarabilities. RedCarpet is doing good job in that respect and rendering markdown in a way which is very close to Github markdown rendering.. just a few points i found missing I have implemented please check .. |
@tas50 any comments on this ? |
src/supermarket/Gemfile
Outdated
@@ -8,6 +8,7 @@ gem "omniauth-chef-oauth2" | |||
gem "omniauth-github" | |||
gem "omniauth-oauth2", "~> 1.7.1" | |||
gem "omniauth-rails_csrf_protection" | |||
gem "coderay" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment on this same line that just says what we're using it for. There's a lot of deps in this file and it's helpful to have comments saying why each one is there # markdown rendering of changelogs
or something like that
Signed-off-by: smriti <sgarg@msystechnologies.com>
020c8ab
to
fd6f456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Signed-off-by: smriti sgarg@msystechnologies.com
Description
substituting html comments with blank string in changelog text for a cookbook.
Updated RedCarpet implementation to match the github markdown rendering standards. Mainly focussed on below two points : -
The above two points are also highlighted by @robbkidd here -> #1321
HTMLpipeline implementation could never be successfull. As its requiring a lot many behavioural changes as application is behaving as of now .. with some serious XSS attacks getting open like injection of javascript via href tag
Issues Resolved
#1831
Check List