Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new url helper for progress.com and updated footer links #2038

Merged

Conversation

msys-sgarg
Copy link
Contributor

Signed-off-by: smriti sgarg@msystechnologies.com

Updated the links in footer which were redirects to progress.com earlier

Description

Footer links are currently pointing to chef.io which are re-directed to progress.com later. I updated the link address to point to progress ip only

Related Issue

#1967

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: smriti <sgarg@msystechnologies.com>
@msys-sgarg msys-sgarg force-pushed the smriti/1967_update_footer_links branch from 7cd6ea1 to 6926bc8 Compare July 8, 2021 14:54
@tas50 tas50 merged commit 4364bb9 into chef:master Jul 8, 2021
@tas50
Copy link
Contributor

tas50 commented Aug 17, 2021

@msys-sgarg This doesn't seem to be working as expected in the current builds. I've installed 3.5.37 build and the links at the bottom of the page try to go to chef.io and 404.

@msys-sgarg
Copy link
Contributor Author

msys-sgarg commented Aug 18, 2021

@tas50 Is the env variable value for "CHEF_WWW_URL" is set to chef.io in your setup ? Because that takes precedence when it comes to decide url for links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants