Changed link for chef dk in directory file #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msys-sgarg
added
the
Status: Sustaining Backlog
tas50
reviewed
Jul 6, 2021
| @@ -107,7 +107,7 @@ | |||
| </li> | |||
|
|
|||
| <li> | |||
| <%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('chef-dk') %> | |||
| <%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('tools/workstation') %> | |||
There was a problem hiding this comment.
Suggested change
| <%= link_to 'Chef Development Kit (Chef DK)', chef_downloads_url('tools/workstation') %> | |
| <%= link_to 'Chef Workstation', chef_downloads_url('tools/workstation') %> |
tas50
reviewed
Jul 6, 2021
| @@ -14,5 +14,10 @@ | |||
| expect(rendered).to have_selector("a[href]", text: test_kitchen_text) | |||
| end | |||
|
|
|||
| it "has chefdk link pointing to correct url" do | |||
| render | |||
| expect(rendered).to have_link("Chef Development Kit (Chef DK)", href: "https://downloads.chef.io/tools/workstation") | |||
There was a problem hiding this comment.
Suggested change
| expect(rendered).to have_link("Chef Development Kit (Chef DK)", href: "https://downloads.chef.io/tools/workstation") | |
| expect(rendered).to have_link("Chef Workstation", href: "https://downloads.chef.io/tools/workstation") |
msys-sgarg
force-pushed
the
smriti/1975_switch_link_chef_dk_cookbooks_directory
branch
from
82d5798
to
1254c19
Compare
@tas50 Did the same please check |
tas50
reviewed
Jul 6, 2021
| @@ -14,5 +14,10 @@ | |||
| expect(rendered).to have_selector("a[href]", text: test_kitchen_text) | |||
| end | |||
|
|
|||
| it "has chefdk link pointing to correct url" do | |||
There was a problem hiding this comment.
Suggested change
| it "has chefdk link pointing to correct url" do | |
| it "has Workstation link pointing to correct url" do |
Signed-off-by: smriti <sgarg@msystechnologies.com>
msys-sgarg
force-pushed
the
smriti/1975_switch_link_chef_dk_cookbooks_directory
branch
from
1254c19
to
349c218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smriti sgarg@msystechnologies.com
Chef Development Kit(Chef-DK) on cookbooks-directory page was pointing to wrong link. Corrected the same
Description
Chef DK link now points to https://downloads.chef.io/tools/workstation as was mentioned in the issue
Related Issue
#1975
Types of changes
Checklist: