Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exceptions thrown by displaying an error #1894

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix exceptions thrown by displaying an error #1894

merged 1 commit into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. fix error page routing and display 

    Rails 5.1 deprecated using `env` in controllers in favor of using
`request.env`. This change switches to that and removes some methods
that are not currently used anywhere.

The result of the `env` calls being in place is that the exception show
page rendering would itself cause an exception. Thus, all errors become
500 errors which heightens the suspicion of upstream proxies and load
balancers. The application logs also get filled with stacktraces for
simple non-matched route errors which no body has time for.

Signed-off-by: Robb Kidd <rkidd@chef.io>
    @robbkidd
    robbkidd committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    b5f5147 View commit details
    Browse the repository at this point in the history