upgrade Ruby to 2.6.5 #1852
Merged
upgrade Ruby to 2.6.5 #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
added
Component: Omnibus
Signed-off-by: Robb Kidd <rkidd@chef.io>
The version of rubygems and bundler must be consistent witht the version included in the embedded Ruby install or we'll get double-bundler problems. * versions overridden in the supermarket software definition * BUNDLED WITH updated in the Gemfile.locks * updated the omnibus and omnibus-software gems to have access to the new versions of components * berkshelf installed as a gem instead of as an omnibus software dependency because it installs from git with bundler and its Gemfile.lock is an older version of bundler that does not match the one this change uses * update the embedded chef-client to latest 14 - the ctl-reconfigure command provided by omnibus-ctl uses the --chef-license switch. Need to update to a version of 14 with that switch backported as a no-op or else supermarket-ctl reconfigure would fail with a message about an invalid option. Signed-off-by: Robb Kidd <rkidd@chef.io>
robbkidd
force-pushed
the
upgrade-ruby-n-such
branch
from
a6060fa
to
e57a761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new version of
chef-zero(a dependency ofchef) bumped to require Ruby 2.6. That requirement has inspired a version bump!Changes to
src/supermarket/Changes to
omnibus/The version of rubygems and bundler must be consistent with the version included in the embedded Ruby install or we'll get double-bundler problems.
BUNDLED WITHupdated in theGemfile.locks to match the version of bundler embedded in the installTypes of changes
Bug fix (non-breaking change which fixes an issue)New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to change)Checklist:
I have updated the documentation accordingly.I have added tests to cover my changes.