upgrade rails to 5.0.7 #1777
Merged
upgrade rails to 5.0.7 #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran rake app:update and committed what changes it made via its templates as appropriate. Keeping these files looking as much like the Rails templates as possible makes reviewing future app:update diffs easier. Changes of note: * config/environments/production.rb Moved our logging configuration to the spots the Rails generators and app:update templates put them. Added a new RAILS_LOG_TO_STDOUT environment variable to the list of env vars set in production to match the Railsy way to declare that. * config/initializers/cookies_serializer.rb Changed to hybrid to "transparently migrate existing Marshal-serialized cookies to the new JSON-based format."[1] [1] https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#cookies-serializer Signed-off-by: Robb Kidd <rkidd@chef.io>
Because the latest is a good thing to have. Because it's the right thing to do. Because there will probably be some factory shenanigans with a Rails 5.0 to 5.1 upgrade. Also moves factorybot and faker to the development & test group because they are sometimes handy in the development environment for cobbling up test data. Also also alphabetized the test group because rubocop likes that. Also also also, resolve deprecation warning about static attributes in factories. Signed-off-by: Robb Kidd <rkidd@chef.io>
robbkidd
force-pushed
the
robb/upgrade-rails
branch
from
1383355
to
ce44f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Rails to the latest point release of our current minor version.
Ran rake app:update and committed what changes it made via its templates as appropriate. Keeping these files looking as much like the Rails templates as possible makes reviewing future app:update diffs easier.
Changes of note:
config/environments/production.rbMoved our logging configuration to the spots the Rails generators and app:update templates put them.
Added a new
RAILS_LOG_TO_STDOUTenvironment variable to the list of env vars set in production to match the Railsy way to declare that.config/initializers/cookies_serializer.rbChanged to hybrid to "transparently migrate existing Marshal-serialized cookies to the new JSON-based format."
Also upgrade Factory{Girl|Bot} factory library in the test suite.