upgrade nokogiri & libxml2 #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded the gem references for nokogiri and upgraded omnibus/-software for an updated libxml2 "system library." Addresses CVE-2017-15412 Signed-off-by: Robb Kidd <rkidd@chef.io>
node.set is deprecated. Use node.default/node.override ... OR just set them in the kitchen config! Signed-off-by: Robb Kidd <rkidd@chef.io>
tas50
reviewed
Feb 20, 2018
| build_user_group: vagrant | ||
| build_user_home: /home/vagrant | ||
| build_dir: /home/vagrant/supermarket/omnibus | ||
| install_dir: /opt/supermarket |
There was a problem hiding this comment.
Does this cookbook only ever run via TK?
There was a problem hiding this comment.
Yup. It's only purpose is to run inside TK-driven builds in a dev environment.
tas50
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the gem references for nokogiri and upgraded omnibus/-software for an updated libxml2 "system library." Addresses CVE-2017-15412
Also, remove
node.set(deprecated) from dev build cookbook.node.setis deprecated. Usenode.default/node.override... OR just set them in the kitchen config!