remove some interpolated default attributes for sensible ocid default #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of removing interpolated values from the omnibus' cookbook attribute defaults. Interpolating the default chef_server_url into chef_identity_url in the defaults caused no end of trouble with onprem installations. The application URL helpers already perform run-time interpolation with the chef_server_url when no env var is present. So we'll leave these attributes unset which will omit them from the list of things that get exported as env vars. Administrators still have the option to set a value for these attributes which will set the associated env var and will override in the Rails app. Signed-off-by: Robb Kidd <rkidd@chef.io>
|
@larryebaum This change, once released, should address the OCID stuff needed for onprem Supermarkets. After this change, you shouldn't need to override |
iennae
approved these changes
Oct 13, 2017
robbkidd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of removing interpolated values from the omnibus' cookbook attribute defaults. Interpolating the default chef_server_url into chef_identity_url in the defaults caused no end of trouble with onprem installations. The application URL helpers already perform run-time interpolation with the chef_server_url when no env var is present. So we'll leave these attributes unset which will omit them from the list of things that get exported as env vars.
Administrators still have the option to set a value for these attributes which will set the associated env var and will override in the Rails app.