add QM pass rate percentage to search results, show page #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookbookVersion now knows how to compute a version's pass rate percentage for quality metrics. Add that display with a gauge to search results and on the Quality tab of the cookbook version display page. Signed-off-by: Robb Kidd <rkidd@chef.io>
|
Screenshots! Search ResultsI note that the metric pass rate and updated date are jogged up a little from the cookbook name and version in the search results. Need to twiddle with the HTML elements containing those items.
Cookbook Show Page (Quality tab)
|
|
@onlyhavecans 👀 📈 |
|
@hannah-radish Please don't cringe. 😬 |
|
@robbkidd opening up a new branch from your branch to make some minor formatting edits |
|
I love it as a first step! ✅ |
iennae
approved these changes
Oct 11, 2017
robbkidd
added
Feature
Component: Quality Metrics
tas50
added
Status: Incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CookbookVersion now knows how to compute a version's pass rate percentage for quality metrics.
Add that display with a gauge to search results and on the Quality tab of the cookbook version display page.