wip: new test for gzippiness

src/supermarket/app/models/cookbook_upload/archive.rb

@@ -92,7 +92,7 @@ def read(path)
     #
     def each_entry
       raise NoPath unless @source.respond_to?(:path)
-      raise NotGzipped unless gzipped?(@source.path)
+      raise NotGzipped if !gzipped?
 
       begin
         ::Archive::Reader.open_filename(@source.path) do |tar|
@@ -112,17 +112,10 @@ def each_entry
     #
     # Determines whether a file at a path is gzipped or not
     #
-    #
     # @return true/false
     #
-    # @example
-    #   archive = CookbookUpload::Archive.new(tarball)
-    #   archive.each do |entry|
-    #     puts "#{entry.full_name} has the following content:\n#{entry.read}"
-    #   end
-    #
-    def gzipped?(file_path)
-      FileMagic.mime.file(file_path) == "application/x-gzip; charset=binary"
+    def gzipped?
+      FileMagic.mime.file(@source.path).match? %r{application\/x?-?gzip;}
     end
   end
 end

src/supermarket/spec/models/cookbook_upload/archive_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe CookbookUpload::Archive do
+  describe '#gzipped?' do
+    it 'returns true if a tar file is GZipped' do
+      tarball = described_class.new(File.new('spec/support/cookbook_fixtures/redis-test-v1.tgz'))
+      expect(tarball.send(:gzipped?)).to be true
+    end
+
+    it 'fails if a tar file is not GZipped' do
+      tarball = described_class.new(File.new('spec/support/cookbook_fixtures/not-actually-gzipped.tgz'))
+      expect(tarball.send(:gzipped?)).to be false
+    end
+  end
+end