Skip to content

Commit

Permalink
Commenting why the change to xargs params
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Powell <powell@progress.com>
  • Loading branch information
tpowell-progress committed Oct 6, 2022
1 parent 28da485 commit 2ee96b9
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/omnibus/health_check.rb
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,12 @@ def health_check_solaris
bad_libs = {}
good_libs = {}

# The case/when below depends on the "current_library" being output with a : at the end
# and then the dependencies on subsequent lines in the form "library.so.1 => /lib/64/library.so.1"
# This output format only happens if ldd is passed multiple libraries (for Solaris, similar to Linux)
# FIXME if any of the `when` clauses in the `health_check_*` methods run before the `current_library`
# they probably should error out with an explicit callout of formatting with their environment's
# respective ldd parsing
read_shared_libs("find #{project.install_dir}/ -type f | xargs file | grep \"ELF\" | awk -F: '{print $1}' | sed -e 's/:$//'", "xargs ldd") do |line|
case line
when /^(.+):$/
Expand Down

0 comments on commit 2ee96b9

Please sign in to comment.