-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ruby3.3 Logger by properly initialize super class #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi, @mtasaka, thanks for your contribution! Responding to this and assigning to myself for visibility. Looks like a couple of CI things have to be cleaned up on our side prior to merge. |
Upcoming ruby3.3 will have enhanced Logger class: ruby/ruby@194520f which initializes newly added instance variables. Without initializing such variables (in super class), now using subclass of Logger will cause exception. To avoid this, first call super, then execute additional subclass initialization. Fixes chef#73. Signed-off-by: Mamoru TASAKA <mtasaka@fedoraproject.org>
tpowell-progress
approved these changes
Jul 9, 2024
tpowell-progress
added
the
Expeditor: Bump Version Minor
Used by github.minor_bump_labels to bump the Minor version number.
label
Jul 9, 2024
stanhu
added a commit
to stanhu/mixlib-log
that referenced
this pull request
Jul 23, 2024
chef#74 fixed an issue with Ruby 3.3's version of Logger. However, it dropped `Mixlib::Log::Formatter` from the formatter, so all messages now output as a Hash instead of a string.
11 tasks
stanhu
added a commit
to stanhu/mixlib-log
that referenced
this pull request
Jul 23, 2024
chef#74 fixed an issue with Ruby 3.3's version of Logger. However, it dropped `Mixlib::Log::Formatter` from the formatter, so all messages now output as a Hash instead of a string. Signed-off-by: Stan Hu <stanhu@gmail.com>
stanhu
added a commit
to stanhu/mixlib-log
that referenced
this pull request
Jul 23, 2024
chef#74 fixed an issue with Ruby 3.3's version of Logger. However, it dropped `Mixlib::Log::Formatter` from the formatter, so all messages now output as a Hash instead of a string. Signed-off-by: Stan Hu <stanhu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Expeditor: Bump Version Minor
Used by github.minor_bump_labels to bump the Minor version number.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming ruby3.3 will have enhanced Logger class:
ruby/ruby@194520f which initializes newly added instance variables.
Without initializing such variables (in super class), now using subclass of Logger will cause exception.
To avoid this, first call super, then execute additional subclass initialization.
Fixes #73.
Types of changes
Checklist: