Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ruby3.3 Logger by properly initialize super class #74

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Sep 26, 2023

Upcoming ruby3.3 will have enhanced Logger class:
ruby/ruby@194520f which initializes newly added instance variables.
Without initializing such variables (in super class), now using subclass of Logger will cause exception.

To avoid this, first call super, then execute additional subclass initialization.

Fixes #73.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@mtasaka mtasaka requested review from a team as code owners September 26, 2023 13:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tpowell-progress tpowell-progress self-assigned this Feb 28, 2024
@tpowell-progress
Copy link
Contributor

Hi, @mtasaka, thanks for your contribution! Responding to this and assigning to myself for visibility. Looks like a couple of CI things have to be cleaned up on our side prior to merge.

@tpowell-progress
Copy link
Contributor

Hi, @mtasaka, thanks for your contribution! Responding to this and assigning to myself for visibility. Looks like a couple of CI things have to be cleaned up on our side prior to merge.

👋 @mtasaka , can you rebase against main? I trimmed out the old ruby versions and had to bumpcucumber

Upcoming ruby3.3 will have enhanced Logger class:
ruby/ruby@194520f
which initializes newly added instance variables.
Without initializing such variables (in super class), now using
subclass of Logger will cause exception.

To avoid this, first call super, then execute additional subclass
initialization.

Fixes chef#73.

Signed-off-by: Mamoru TASAKA <mtasaka@fedoraproject.org>
@tpowell-progress tpowell-progress added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Jul 9, 2024
@tpowell-progress tpowell-progress merged commit c9d3e92 into chef:main Jul 12, 2024
2 of 3 checks passed
stanhu added a commit to stanhu/mixlib-log that referenced this pull request Jul 23, 2024
chef#74 fixed an issue
with Ruby 3.3's version of Logger. However, it dropped
`Mixlib::Log::Formatter` from the formatter, so all messages
now output as a Hash instead of a string.
stanhu added a commit to stanhu/mixlib-log that referenced this pull request Jul 23, 2024
chef#74 fixed an issue
with Ruby 3.3's version of Logger. However, it dropped
`Mixlib::Log::Formatter` from the formatter, so all messages
now output as a Hash instead of a string.

Signed-off-by: Stan Hu <stanhu@gmail.com>
stanhu added a commit to stanhu/mixlib-log that referenced this pull request Jul 23, 2024
chef#74 fixed an issue
with Ruby 3.3's version of Logger. However, it dropped
`Mixlib::Log::Formatter` from the formatter, so all messages
now output as a Hash instead of a string.

Signed-off-by: Stan Hu <stanhu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rspec testsuite fails with ruby 3.3.0dev
2 participants