Add an autocorrect for insecure gitlab/github source/issue url metadata #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These represent almost all of the community cookbook and this makes sure folks are using secure URLs Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tyler-ball
reviewed
Jul 16, 2019
|
|
||
| def autocorrect(node) | ||
| lambda do |corrector| | ||
| corrector.replace(node.loc.expression, node.source.gsub(%r{http://(www.)*}, 'https://')) |
There was a problem hiding this comment.
I think this replacer will remove www from the string since it will match on it. I think you could just .gsub(%r{^http://}, 'https://') instead
There was a problem hiding this comment.
Removing www is part of it. Those just redirect on both sites
There was a problem hiding this comment.
Thanks! I did not realize that
Signed-off-by: Tim Smith <tsmith@chef.io>
tyler-ball
approved these changes
Jul 16, 2019
|
|
||
| def autocorrect(node) | ||
| lambda do |corrector| | ||
| corrector.replace(node.loc.expression, node.source.gsub(%r{http://(www.)*}, 'https://')) |
There was a problem hiding this comment.
Thanks! I did not realize that
tas50
added
the
Expeditor: Bump Version Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These represent almost all of the community cookbook and this makes sure folks are using secure URLs
Signed-off-by: Tim Smith tsmith@chef.io