Disable cop with potentially misleading warning message.

[phiggins]

Signed-off-by: Pete Higgins pete@peterhiggins.org

This came up in the PR on chef/chef-server: https://github.com/chef/chef-server/pull/2174/files#r527113845

The warning from this cop led the PR author to change this code:

Chef::Node.send(:include, ChefOpsDCC::Helpers)

to this syntactically valid but incorrect code:

Chef::Node.send(include ChefOpsDCC::Helpers)

[lamont-granquist]

I tend to think this is a good cop, but maybe needs to be engaged with the rubocop authors to clean up the warning message.

Also isn't there an autocorrect for this which does the right thing?

[phiggins]

I tend to think this is a good cop, but maybe needs to be engaged with the rubocop authors to clean up the warning message.

I agree, I think the main problem with this is the warning message.

Also isn't there an autocorrect for this which does the right thing?

There is, but to someone unfamiliar with rubocop/chefstyle/cookstyle it's not obvious that that exists. I would be in favor of rubocop adding some kind of newbie friendly message at the end of a run that's something like there are warnings present that can be autofixed. Run $executable_name -a to fix them.