Add ChefCorrectness/InvalidDefaultAction cop #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detect when people are setting it to something that isn't a variable, symbol, or array. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Jul 17, 2020
phiggins
reviewed
Jul 17, 2020
spec/rubocop/cop/chef/correctness/invalid_default_action_spec.rb
Outdated
Show resolved
Hide resolved
phiggins
reviewed
Jul 17, 2020
| it 'does not register an offense with a variable' do | ||
| expect_no_offenses('default_action [:create, :enable]') | ||
| end | ||
| end |
There was a problem hiding this comment.
I might add a test for an array of non-symbols.
There was a problem hiding this comment.
Right now I just sorta pass on detecting that. Any array is fine. I saw my first case of someone using that while writing this and I don't think anyone really realizes it's even an option.
phiggins
approved these changes
Jul 17, 2020
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when people are setting it to something that isn't a variable, symbol, or array.
Signed-off-by: Tim Smith tsmith@chef.io