Add new cop ChefModernize/ConditionalUsingTest #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid shelling out when we can just use Ruby which is going to be faster. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
Jul 9, 2020
phiggins
reviewed
Jul 9, 2020
phiggins
reviewed
Jul 9, 2020
phiggins
reviewed
Jul 9, 2020
| not_if { ::File.exist?('/sbin/apt') } | ||
| end | ||
| RUBY | ||
| end |
There was a problem hiding this comment.
I could see this being a tiny bit confusing if the user uses test -e and this suggests not using test -f.
Also this is the nitpickiest of nitpicks, but someone could want the behavior of -f that does more than test for existence.
There was a problem hiding this comment.
Yeah -f is a bit different than File.exist?, but looking at how users were using it throughout supermarket cookbooks they were just looking for File.exist? functionality. Someone out there isn't going to like this and for that user they can disable it inline or entirely in a .rubocop.yml. For most people, I think it gives the appropriate direction.
phiggins
approved these changes
Jul 9, 2020
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Signed-off-by: Tim Smith <tsmith@chef.io> Co-authored-by: pete higgins <pete@peterhiggins.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid shelling out when we can just use Ruby which is going to be faster.
Fixes #543
Signed-off-by: Tim Smith tsmith@chef.io