Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop engine to 0.87.1 #664

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Update RuboCop engine to 0.87.1 #664

merged 2 commits into from
Jul 9, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 7, 2020

Signed-off-by: Tim Smith tsmith@chef.io

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners July 7, 2020 21:10
@tas50
Copy link
Contributor Author

tas50 commented Jul 7, 2020

I need to track down a workaround for the processed_source.path now being nil in the autocorrect method. I filed an issue upstream to see if this was intentional or not.

It looks like the autocorrect code always fires now, which broke this cop since it's making changes outside the Rubocop framework.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Jul 9, 2020
@tas50 tas50 merged commit 7b05605 into master Jul 9, 2020
@chef-expeditor chef-expeditor bot deleted the bump_rubocop branch July 9, 2020 00:09
tyler-ball added a commit to chef/chefstyle that referenced this pull request Jul 9, 2020
To correspond with chef/cookstyle#664 and
ensure chef-workstation can resolve its mega Gemfile.lock

Signed-off-by: tyler-ball <tball@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants