Add new cops for incorrect platforms / platform families #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This time let's catch them in case statements. There's some code reuse in these cops, but it's actually a lot simpler to just write it as two cops vs. trying to create a unified cop. Signed-off-by: Tim Smith <tsmith@chef.io>
phiggins
reviewed
May 27, 2020
lib/rubocop/cop/chef/correctness/invalid_platform_family_values_in_case.rb
Outdated
Show resolved
Hide resolved
phiggins
reviewed
May 27, 2020
lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb
Outdated
Show resolved
Hide resolved
phiggins
approved these changes
May 27, 2020
Signed-off-by: Tim Smith <tsmith@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time let's catch them in case statements. There's some code reuse
in these cops, but it's actually a lot simpler to just write it as two
cops vs. trying to create a unified cop.
Signed-off-by: Tim Smith tsmith@chef.io