Add a new ChefRedundantCode and ChefSharing cop groups #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move some of the chefmodernize and chefcorrect cops into this new group. This is for purely redundant code, not code that was made redundant by a newer version of chef. Chef Modernize will still hold cops that require a specific version of Chef before they can be run. This group should be safe regardless of Chef release. Signed-off-by: Tim Smith <tsmith@chef.io>
This gets us closer to ChefCorrectness only containing things that would potentially break a Chef run Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
Signed-off-by: Tim Smith <tsmith@chef.io>
marcparadise
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some of the chefmodernize and chefcorrect cops into these new groups.
ChefRedundant is for purely redundant code, not code that was made redundant by a newer version of chef. Chef Modernize will still hold cops that require a specific version of Chef before they can be run. This group should be safe regardless of Chef release.
ChefSharing is for things you would want to fix before you shared your code with other teams or shared it on the Supermarket.
Signed-off-by: Tim Smith tsmith@chef.io