Fix ChefModernize/UnnecessaryDependsChef14 to detect version constraints #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
Update the node match to match any AST nodes after the method which will include any version constraint. I also improved the warning and docs for this cop. Signed-off-by: Tim Smith <tsmith@chef.io>
In general I try to keep the message pretty short, but I think this actually gives the user pretty critical information on why you shouldn't do that. Signed-off-by: Tim Smith <tsmith@chef.io> Co-Authored-By: Salim Afiune <afiune@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
fix_UnnecessaryDependsChef14
branch
from
0de87a6
to
e5cb7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the node match to match any AST nodes after the method which will include any version constraint. I also improved the warning and docs for this cop.
Signed-off-by: Tim Smith tsmith@chef.io