Add ChefStyle/UsePlatformHelpers cop #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move people towards our platform? and platform_family? helpers to simplify the platform checks in their recipes / resources. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
force-pushed
the
platform_helpers
branch
from
ce07d06
to
18dd581
Compare
afiune
approved these changes
Sep 10, 2019
| # | ||
| # @example | ||
| # | ||
| # # bad |
There was a problem hiding this comment.
uhmmmm. Is this a WARN or and ERROR? Meaning if this is a recommendation to make the code better or a thing the user /must/ change because it is a /bad/ usage?
It is a bit confusing to call a few cops bad/good. Maybe we can chat about it over zoom/standup. (thought just keep merging things since that has been the pattern we follow)
There was a problem hiding this comment.
At the moment everything is a warning. We're not failing builds with any new cops until April 2020 when some of these will move to failures and some will remain at the refactor level.
tas50
added
the
Expeditor: Bump Version Minor
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move people towards our platform? and platform_family? helpers to simplify the platform checks in their recipes / resources.
Signed-off-by: Tim Smith tsmith@chef.io