Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the fail level to :convention and set rules to :refactor level #117

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 19, 2019

This way we can introduce new rules without failing builds. They'll warn to the console and auto correct, but they won't fail CI

Signed-off-by: Tim Smith tsmith@chef.io

Copy link

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is less obvious to me what it is doing but given the description and code looks reasonable to me.

This way we can introduce new rules without failing builds. They'll warn to the console and auto correct, but they won't fail CI

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 merged commit e047d60 into master Jul 19, 2019
@chef-ci chef-ci deleted the level branch July 19, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants