Move AttributeMetadata cop as well

Signed-off-by: Tim Smith <tsmith@chef.io>
chef · Dec 9, 2019 · dd29ab9 · dd29ab9
1 parent 8432bc8
commit dd29ab9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...op/chef/deprecation/attribute_metadata.rb → .../cop/chef/modernize/attribute_metadata.rb b/...op/chef/deprecation/attribute_metadata.rb → .../cop/chef/modernize/attribute_metadata.rb
@@ -18,8 +18,8 @@
 module RuboCop
   module Cop
     module Chef
-      module ChefDeprecations
-        # Don't use the deprecated 'attribute' metadata value
+      module ChefModernize
+        # The attribute metadata.rb method is not used and is unnecessary in cookbooks.
         #
         # @example
         #
@@ -33,7 +33,7 @@ module ChefDeprecations
         #              default: '"127.0.0.1:2181"'
         #
         class AttributeMetadata < Cop
-          MSG = "Don't use the deprecated 'attribute' metadata value".freeze
+          MSG = 'The attribute metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
           def on_send(node)
             add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :attribute

diff --git a/...ef/deprecation/attribute_metadata_spec.rb → ...chef/modernize/attribute_metadata_spec.rb b/...ef/deprecation/attribute_metadata_spec.rb → ...chef/modernize/attribute_metadata_spec.rb
@@ -16,13 +16,13 @@
 
 require 'spec_helper'
 
-describe RuboCop::Cop::Chef::ChefDeprecations::AttributeMetadata, :config do
+describe RuboCop::Cop::Chef::ChefModernize::AttributeMetadata, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'registers an offense when metadata uses "attribute"' do
     expect_offense(<<~RUBY)
       attribute 'foo'
-      ^^^^^^^^^^^^^^^ Don't use the deprecated 'attribute' metadata value
+      ^^^^^^^^^^^^^^^ The attribute metadata.rb method is not used and is unnecessary in cookbooks.
     RUBY
 
     expect_correction("\n")