Merge pull request #732 from chef/ResourceOverridesProvidesMethod

Signed-off-by: Tim Smith <tsmith@chef.io>

lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb

@@ -33,11 +33,12 @@ module ChefDeprecations
         #
         class ResourceOverridesProvidesMethod < Base
           MSG = "Don't override the provides? method in a resource provider. Use provides :SOME_PROVIDER_NAME instead. This will cause failures in Chef Infra Client 13 and later."
-          RESTRICT_ON_SEND = [:provides?].freeze
 
           def_node_search :provides, '(send nil? :provides ...)'
 
           def on_def(node)
+            return unless node.method_name == :provides?
+
             add_offense(node, message: MSG, severity: :warning) if provides(processed_source.ast).count == 0
           end
         end

spec/rubocop/cop/chef/deprecation/resource_overrides_provides_method_spec.rb

@@ -38,4 +38,12 @@ def provides?
       end
     RUBY
   end
+
+  it "doesn't register an offense with any old method" do
+    expect_no_offenses(<<~RUBY)
+      def foo
+       true
+      end
+    RUBY
+  end
 end