Update the Rubocop engine to 0.72

.expeditor/config.yml

@@ -12,6 +12,8 @@ rubygems:
 github:
   # This deletes the GitHub PR branch after successfully merged into the release branch
   delete_branch_on_merge: true
+  # The tag format to use (e.g. v1.0.0)
+  version_tag_format: "v{{version}}"
   # allow bumping the minor release via label
   minor_bump_labels:
     - "Expeditor: Bump Version Minor"

.expeditor/verify.pipeline.yml

@@ -2,27 +2,27 @@ steps:
 
 - label: run-specs-ruby-2.4
   command:
-    - asdf local ruby 2.4.5
-    - bundle install --jobs=7 --retry=3
+    - bundle install --jobs=7 --retry=3 --without docs debug
     - bundle exec rake style
   expeditor:
     executor:
       docker:
+        image: ruby:2.4-stretch
 
 - label: run-specs-ruby-2.5
   command:
-    - asdf local ruby 2.5.5
-    - bundle install --jobs=7 --retry=3
+    - bundle install --jobs=7 --retry=3 --without docs debug
     - bundle exec rake style
   expeditor:
     executor:
       docker:
+        image: ruby:2.5-stretch
 
 - label: run-specs-ruby-2.6
   command:
-    - asdf local ruby 2.6.3
-    - bundle install --jobs=7 --retry=3
+    - bundle install --jobs=7 --retry=3 --without docs debug
     - bundle exec rake style
   expeditor:
     executor:
       docker:
+        image: ruby:2.6-stretch

.github/CODEOWNERS

@@ -1,5 +1,5 @@
 # Order is important. The last matching pattern has the most precedence.
 
-*                 @chef/chef-foundation-reviewers
-.expeditor/**     @chef/jex-team
-*.md              @chef/docs-team
+*               @chef/chef-foundation-reviewers
+.expeditor/     @chef/jex-team
+*.md            @chef/docs-team

config/chefstyle.yml

@@ -66,8 +66,6 @@ Lint/InheritException:
   Enabled: true
 Lint/IneffectiveAccessModifier:
   Enabled: true
-Lint/InvalidCharacterLiteral:
-  Enabled: true
 Lint/LiteralInCondition:
   Enabled: true
 Lint/LiteralInInterpolation:
@@ -104,8 +102,6 @@ Lint/UnderscorePrefixedVariableName:
   Enabled: true
 Lint/UnifiedInteger:
   Enabled: true
-Lint/UnneededDisable:
-  Enabled: true
 Lint/UnneededSplatExpansion:
   Enabled: true
 Lint/UnreachableCode:
@@ -144,88 +140,6 @@ Lint/RescueException:
 Lint/UnneededDisable:
   Enabled: false
 
-#
-# Performance
-#
-
-Performance/Casecmp:
-  Enabled: true
-Performance/CaseWhenSplat:
-  Enabled: true
-Performance/CompareWithBlock:
-  Enabled: true
-Performance/Count:
-  Enabled: true
-Performance/Detect:
-  Enabled: true
-Performance/DoubleStartEndWith:
-  Enabled: true
-Performance/EndWith:
-  Enabled: true
-Performance/FixedSize:
-  Enabled: true
-Performance/FlatMap:
-  Enabled: true
-Performance/HashEachMethods:
-  Enabled: true
-Performance/LstripRstrip:
-  Enabled: true
-Performance/RangeInclude:
-  Enabled: true
-Performance/RedundantBlockCall:
-  Enabled: true
-Performance/RedundantMatch:
-  Enabled: true
-Performance/RedundantMerge:
-  Enabled: true
-Performance/RedundantSortBy:
-  Enabled: true
-Performance/RegexpMatch:
-  Enabled: true
-Performance/ReverseEach:
-  Enabled: true
-Performance/Sample:
-  Enabled: true
-Performance/Size:
-  Enabled: true
-Performance/SortWithBlock:
-  Enabled: true
-Performance/StartWith:
-  Enabled: true
-Performance/StringReplacement:
-  Enabled: true
-Performance/TimesMap:
-  Enabled: true
-
-#
-# Rails
-#
-
-Rails/ActionFilter:
-  Enabled: true
-Rails/Date:
-  Enabled: true
-Rails/Delegate:
-  Enabled: true
-Rails/FindBy:
-  Enabled: true
-Rails/FindEach:
-  Enabled: true
-Rails/HasAndBelongsToMany:
-  Enabled: true
-Rails/Output:
-  Enabled: true
-Rails/PluralizationGrammar:
-  Enabled: true
-Rails/ReadWriteAttribute:
-  Enabled: true
-Rails/ScopeArgs:
-  Enabled: true
-Rails/TimeZone:
-  Enabled: true
-Rails/Validation:
-  Enabled: true
-
 #
 # Security
 #
@@ -319,12 +233,10 @@ Style/EvenOdd:
   Enabled: true
 Layout/ExtraSpacing:
   Enabled: true
-Style/FlipFlop:
+Lint/FlipFlop:
   Enabled: true
 Style/For:
   Enabled: true
-Style/FrozenStringLiteralComment:
-  Enabled: true
 Style/HashSyntax:
   Enabled: true
 Naming/HeredocDelimiterCase:
@@ -384,7 +296,7 @@ Style/NumericPredicate:
   EnforcedStyle: comparison
 Style/OneLineConditional:
   Enabled: true
-Style/OpMethod:
+Naming/BinaryOperatorParameterName:
   Enabled: true
 Style/OptionalArguments:
   Enabled: true
@@ -492,7 +404,10 @@ Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
 # rubocop's default gets this completely backwards
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArray:
+  Enabled: true
+  EnforcedStyleForMultiline: comma
+Style/TrailingCommaInHash:
   Enabled: true
   EnforcedStyleForMultiline: comma
 Style/TrailingUnderscoreVariable:
@@ -570,7 +485,7 @@ Style/Encoding:
   Enabled: false
 
 # Dan is -1 on this one: https://github.com/chef/chef/pull/4526#issuecomment-179950045
-Layout/IndentHash:
+Layout/IndentFirstHashElement:
   Enabled: false
 
 # This is overly aggressive and autofix broke stuff, would need to exclude classes
@@ -623,6 +538,12 @@ Style/SpecialGlobalVars:
 Style/GuardClause:
   Enabled: false
 
+Style/RedundantSortBy:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
 # Let authors order gems however makes sense
 Bundler/OrderedGems:
   Enabled: false