Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keys mode undocumented at all #309

Closed
jsirex opened this issue Mar 5, 2018 · 4 comments
Closed

Keys mode undocumented at all #309

jsirex opened this issue Mar 5, 2018 · 4 comments

Comments

@jsirex
Copy link

jsirex commented Mar 5, 2018

Help says:
" -K, --keys-mode KEYS_MODE Mode in which to save vault keys"
What is the "KEYS_MODE"? Which values are possible?
Do you have any use cases? Could you please improve help?
@thommay
Copy link
Contributor

thommay commented Mar 5, 2018

Thanks for the bug report. Yes, we should improve the help. In summary, the mode is either default, which saves all the copies of the client encrypted symmettric key into a single item_keys data bag item, or sparse, which creates a new data bag item per client. Sparse helps performance a lot for really large (greater than a thousand clients) vault usage.

@josephmilla
Copy link

@thommay to be honest, why not just use sparse mode as the default?

@jeunito
Copy link
Contributor

jeunito commented Oct 20, 2018

@jsirex created a PR for that in #325

@sanga1794
Copy link
Contributor

PR #325 got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thommay @jeunito @jsirex @josephmilla @sanga1794