vdso-compat: Increase the reserved buffer for compat vdso #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Arch Linux with 5.18.3-zen1-1-zen kernel, the vdso's size is 3 pages which exceeds the current 2-page reserved buffer. This commit simply increases the reserved buffer size to 4 pages. Fixes: checkpoint-restore#1916 Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
|
Looks reasonable. Did you manage to find zen-kernel specific patch which changed compat vdso size? |
|
I can't see either, I guess it's because the compiler they use to build the kernel or maybe they set some configs. |
|
cc @0x7f454c46 |
|
Seems reasonable. We could probably mmap() a bigger buffer as likely most systems have overcommit enabled and it won't consume any memory before the vdso pages are copied out to the buffer. |
0x7f454c46
approved these changes
Jul 22, 2022
|
im getting this |
|
@tuananh could you file a new issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Arch Linux with 5.18.3-zen1-1-zen kernel, the vdso's size is 3 pages which
exceeds the current 2-page reserved buffer. This commit simply increases the
reserved buffer size to 4 pages.
Fixes: #1916
Signed-off-by: Bui Quang Minh minhquangbui99@gmail.com