Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gum spin show output only when failed #512

Closed
devonpmack opened this issue Mar 12, 2024 · 3 comments
Closed

gum spin show output only when failed #512

devonpmack opened this issue Mar 12, 2024 · 3 comments

Comments

@devonpmack
Copy link

Is your feature request related to a problem? Please describe.

Gum spin is great when nothing goes wrong we can hide all the output. But if it fails it currently swallows the error message.

Describe the solution you'd like

Show the output when gum spin fails.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@maaslalani
Copy link
Contributor

Hey @devonpmack, nice to see you here! 😄

Have you tried the --show-output flag? It will output both stderr and stdout while using gum spin. If I'm understanding correctly you only want the output on error though right? Perhaps we want a similar --show-error flag as implemented in:

@devonpmack
Copy link
Author

devonpmack commented Mar 13, 2024

Hiii @maaslalani 😲😲 Yes the --show-error will be perfect here! Maybe it should even be the default? Thank you!

@maaslalani
Copy link
Contributor

Fixed in #518!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants