test: side by side test fixes #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tihuan
commented
Jun 18, 2024
| @@ -32,10 +32,6 @@ describe("CellGuideCXG", () => { | |||
| test("page launched", async ({ page }, testInfo) => { | |||
| await goToPage(page, pageURLCellGuide); | |||
|
|
|||
| const element = await page.getByTestId("header").innerHTML(); | |||
|
|
|||
| expect(element).toMatchSnapshot(); | |||
There was a problem hiding this comment.
Use Chromatic screenshot for better DX. Here and throughout
| .getByTestId(`category-${label}`) | ||
| .innerHTML(); | ||
|
|
||
| expect(element).toMatchSnapshot(); |
There was a problem hiding this comment.
removed this one and the following, since the bottom chromatic snapshot should capture them anyway
| /** | ||
| * (thuang): If the side panel is not open, don't take its layout choice into account | ||
| */ | ||
| open && |
There was a problem hiding this comment.
this is to resolve the bug when side panel is off, the image layer toggle button would still show up when the main panel is switched to a non-spatial embedding
| !isSidePanel && | ||
| !e.currentTarget.value.includes(globals.spatialEmbeddingKeyword) | ||
| ) { | ||
| dispatch({ |
There was a problem hiding this comment.
this is not needed anymore, since the toggle state should only be controlled by the image toggle button only
| stateChanges.toolSVG | ||
| ) { | ||
| const { tool } = this.state; | ||
| this.selectionToolUpdate(stateChanges.tool ? stateChanges.tool : tool!); |
There was a problem hiding this comment.
this needs to be added back to resolve the lasso element missing bug
tihuan
changed the title
tihuan
changed the title
tihuan
force-pushed
the
feat/side-by-side
branch
from
cf41e62
to
c5f9dd7
Compare
tihuan
force-pushed
the
kaloster/side-by-side-test-fix
branch
from
e6cccf3
to
2621d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.