-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: side by side test fixes #989
Conversation
@@ -32,10 +32,6 @@ describe("CellGuideCXG", () => { | |||
test("page launched", async ({ page }, testInfo) => { | |||
await goToPage(page, pageURLCellGuide); | |||
|
|||
const element = await page.getByTestId("header").innerHTML(); | |||
|
|||
expect(element).toMatchSnapshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Chromatic screenshot for better DX. Here and throughout
.getByTestId(`category-${label}`) | ||
.innerHTML(); | ||
|
||
expect(element).toMatchSnapshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this one and the following, since the bottom chromatic snapshot should capture them anyway
/** | ||
* (thuang): If the side panel is not open, don't take its layout choice into account | ||
*/ | ||
open && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to resolve the bug when side panel is off, the image layer toggle button would still show up when the main panel is switched to a non-spatial embedding
!isSidePanel && | ||
!e.currentTarget.value.includes(globals.spatialEmbeddingKeyword) | ||
) { | ||
dispatch({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed anymore, since the toggle state should only be controlled by the image toggle button only
stateChanges.toolSVG | ||
) { | ||
const { tool } = this.state; | ||
this.selectionToolUpdate(stateChanges.tool ? stateChanges.tool : tool!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be added back to resolve the lasso element missing bug
cf41e62
to
c5f9dd7
Compare
e6cccf3
to
2621d08
Compare
No description provided.