Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spatial): use global api prefix for /spatial/meta calls #822

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

seve
Copy link
Contributor

@seve seve commented Mar 12, 2024

So the /spatial/meta endpoint is 404'ing, but it’s 404'ing when trying to access via cellxgene/e/super-cool-spatial.cxg/api/v0.3/spatial/meta not cellxgene/s3_uri/s3%253A%252F%252Fhosted-cellxgene-dev%252Fsuper-cool-spatial.cxg/api/v0.3/spatial/meta

@seve seve requested review from tihuan and kaloster March 12, 2024 17:29
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (9a68bdb) to head (a6ac7c6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   76.57%   76.57%           
=======================================
  Files          88       88           
  Lines        6994     6994           
=======================================
  Hits         5356     5356           
  Misses       1638     1638           
Flag Coverage Δ
frontend 76.57% <ø> (ø)
javascript 76.57% <ø> (ø)
smokeTest ∅ <ø> (?)
unitTest 76.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaloster kaloster merged commit 2e286ba into main Mar 12, 2024
6 of 7 checks passed
@kaloster kaloster deleted the seve/fix-spatial-meta branch March 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants