test: add snapshots to graph related tests also disable chromatic on geneset names and tooltips #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 88 88
Lines 6856 6856
=======================================
Hits 5312 5312
Misses 1544 1544
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
seve
commented
Feb 29, 2024
| const imageID = "graph-image"; | ||
| await page.getByTestId(buttonID).click(); | ||
| page.getByTestId(imageID).waitFor(); | ||
| await takeSnapshot(page, testInfo); |
There was a problem hiding this comment.
I'm making the assumption that chromatic will offer a diff from this?
There was a problem hiding this comment.
that's correct! Chromatic saves the latest approved snapshot in its own DB to diff with each PR!
seve
commented
Feb 29, 2024
client/__tests__/e2e/e2e.test.ts
Outdated
| await setup(option, page); | ||
| await createGeneset(meanExpressionBrushGenesetName, page); | ||
| await addGeneToSetAndExpand(meanExpressionBrushGenesetName, "SIK1", page); | ||
|
|
||
| await colorByGeneset(meanExpressionBrushGenesetName, page); | ||
| await assertColorLegendLabel(meanExpressionBrushGenesetName, page); | ||
| snapshotTestGraph(page, testInfo); |
seve
commented
Feb 29, 2024
client/__tests__/e2e/e2e.test.ts
Outdated
| @@ -379,6 +385,7 @@ describe("ui elements don't error", () => { | |||
| await drag("layout-graph", panCoords.start, panCoords.end, page); | |||
|
|
|||
| await page.evaluate("window.scrollBy(0, 1000);"); | |||
| snapshotTestGraph(page, testInfo); | |||
seve
commented
Feb 29, 2024
There was a problem hiding this comment.
looks prettier ran its course on the file, ive commented the actual diffs
seve
commented
Feb 29, 2024
| @@ -1,5 +1,4 @@ | |||
| import { ReporterDescription, defineConfig, devices } from "@playwright/test"; | |||
| import { COMMON_PLAYWRIGHT_CONTEXT } from "./__tests__/common/playwrightContext"; | |||
There was a problem hiding this comment.
deleted this constant in favor of declaring it in this file
seve
commented
Feb 29, 2024
Comment on lines
+95
to
+96
| data-testid={`geneset-description-tooltip-${originalString}${tooltipAddendum}`} | ||
| data-chromatic="ignore" |
seve
commented
Feb 29, 2024
| @@ -128,6 +128,7 @@ class GeneSet extends React.Component<{}, State> { | |||
| maxWidth: globals.leftSidebarWidth - genesetNameLengthVisible, | |||
| }} | |||
| data-testid={`${setName}:geneset-name`} | |||
| data-chromatic="ignore" | |||
seve
force-pushed
the
seve/graph-test
branch
from
be277cc
to
8fa8dc4
Compare
tihuan
approved these changes
Mar 5, 2024
seve
force-pushed
the
seve/graph-test
branch
2 times, most recently
from
0efea50
to
1325cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#716 #760
Adds a util to take a snapshot of the graph for doing visual diff testing. Also prevents chromatic from recognizing the geneset names as diffs