Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable portion of noisy env screenshots #75

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

seve
Copy link
Contributor

@seve seve commented Sep 21, 2021

No description provided.

@seve seve requested a review from tihuan September 21, 2021 17:07
@seve seve enabled auto-merge (squash) September 21, 2021 17:09
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #75 (d1503b6) into main (8758ce5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   71.72%   71.72%           
=======================================
  Files         126      126           
  Lines       10030    10030           
=======================================
  Hits         7194     7194           
  Misses       2836     2836           
Flag Coverage Δ
frontend 71.72% <ø> (ø)
javascript 71.72% <ø> (ø)
smokeTest ?
unitTest 71.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8758ce5...d1503b6. Read the comment docs.

Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Seve!

Ah maybe comment them out, so we can use them for debugging flaky tests in the future?

Thank you!

@seve seve merged commit 47b206a into main Sep 21, 2021
@seve seve deleted the seve/prune-screnshot-env branch September 21, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants