Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 717 Add Chromatic and Storybook #723

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Jan 31, 2024

  1. Add Chromatic e2e test to GHA, which automatically captures screenshots in e2e tests
  2. Hook up Chromatic UI Review with PR

NOTES:

  1. This is still a beta feature and their doc is available here: https://www.chromatic.com/docs/playwright/
Screenshot 2024-02-05 at 1 56 55 PM Screenshot 2024-02-05 at 1 57 02 PM

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f31b2b) 77.69% compared to head (0316b84) 77.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   77.69%   77.70%           
=======================================
  Files          88       88           
  Lines        6780     6782    +2     
=======================================
+ Hits         5268     5270    +2     
  Misses       1512     1512           
Flag Coverage Δ
frontend 77.70% <100.00%> (+<0.01%) ⬆️
javascript 77.70% <100.00%> (+<0.01%) ⬆️
smokeTest ?
unitTest 77.70% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tihuan tihuan force-pushed the thuang-717-add-chromatics branch 3 times, most recently from d7f1be3 to d2640d1 Compare February 5, 2024 18:46
@tihuan tihuan marked this pull request as ready for review February 5, 2024 22:40
"repository": "https://github.com/chanzuckerberg/cellxgene",
"repository": {
"type": "git",
"url": "git+https://github.com/chanzuckerberg/cellxgene.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably update this to explorer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call thank you! Updated 👍 !

@tihuan tihuan merged commit 3977efd into main Feb 6, 2024
7 checks passed
@tihuan tihuan deleted the thuang-717-add-chromatics branch February 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants