Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Continuous legend properly disappears after coloring by continuous metadata and subsequently coloring by anything else #513

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky changed the title issue: 512 fix: Continuous legend properly disappears after coloring by continuous metadata and subsequently coloring by anything else Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #513 (c0f2fd4) into main (a75caf1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files          97       97           
  Lines        7647     7647           
=======================================
  Hits         5683     5683           
  Misses       1964     1964           
Flag Coverage Δ
frontend 74.30% <ø> (ø)
javascript 74.30% <ø> (ø)
smokeTest ?
unitTest 74.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atarashansky atarashansky marked this pull request as ready for review October 19, 2022 23:43
@maniarathi
Copy link
Contributor

Is there any way to add a test to make sure this doesn't happen again in the future?

@atarashansky atarashansky enabled auto-merge (squash) October 21, 2022 23:21
@atarashansky atarashansky merged commit fa59fa5 into main Oct 21, 2022
@atarashansky atarashansky deleted the atar/512-fix branch October 21, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants