-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Docker-compose specify platform to get around arm vs amd arch mismatches #241
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -3,7 +3,7 @@ | |||||||
"terraform_version": "0.13.5", | ||||||||
"default_env": "rdev", | ||||||||
"app": "hosted-cellxgene", | ||||||||
"default_compose_env": ".env.ecr", | ||||||||
"default_compose_env_file": ".env.ecr", | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I will keep both for now so that we don't break python There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh woops, maybe I should have been the one to accept this suggestion prior to approval? looks like it merged w/o it. |
||||||||
"environments": { | ||||||||
"rdev": { | ||||||||
"aws_profile": "single-cell-dev", | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a happy golang related change or was it just broken? If the former, do we also need to update config_version to v2? (per these docs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will do those once we've migrated