-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replaced deprecated method to open TileDB array (#56) #236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 76.49% 76.47% -0.03%
==========================================
Files 92 92
Lines 6764 6758 -6
==========================================
- Hits 5174 5168 -6
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
server/dataset/cxg_dataset.py
Outdated
@@ -187,7 +187,7 @@ def _validate_and_initialize(self): | |||
|
|||
@staticmethod | |||
def _open_array(uri, tiledb_ctx): | |||
with tiledb.Array(uri, mode="r", ctx=tiledb_ctx) as array: | |||
with tiledb.open(uri, mode="r", ctx=tiledb_ctx) as array: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this more closely, can't this entire function be replaced with a single call to tiledb.open?
Ie, return tiledb.open(uri, mode="r", ctx=tiledb_ctx)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, good point! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reviewers
Functional:
Readability:
Changes
tiledb.Array()
withtiledb.open()