feat: side by side #977
Merged
feat: side by side #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So excited for this feature branch! For visibility, I added a comment for two bugs PTAL thank you 🙏 |
tihuan
force-pushed
the
feat/side-by-side
branch
from
cf41e62
to
c5f9dd7
Compare
Co-authored-by: kaloster <rkalo@contractor.chanzuckerberg.com>
tihuan
reviewed
Jul 5, 2024
| } = this.props; | ||
|
|
||
| const { colorAccessor } = colors; |
There was a problem hiding this comment.
not sure why this was changed to get from colors instead of keeping it in { colorAccessor } = asyncProps below. But this seems to be causing bug #1022
There was a problem hiding this comment.
This is the PR against feature branch that added this code
https://github.com/chanzuckerberg/single-cell-explorer/pull/964/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch merge. All commits have had their own PR with respective code reviews.