chore: beanstalk cleanup #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 90 90
Lines 6660 6660
=======================================
Hits 5070 5070
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MDunitz
reviewed
May 17, 2022
| zip -r ../artifact.zip . --exclude server/tests/\* server/eb/\* ; ); \ | ||
| if ! grep artifact.zip .elasticbeanstalk/config.yml ; then \ | ||
| mkdir -p .elasticbeanstalk ; cat config_deploy.yaml >> .elasticbeanstalk/config.yml ; fi | ||
|
|
||
| .PHONY: build-ecs | ||
| build-ecs: clean |
There was a problem hiding this comment.
can this be moved to the base makefile?
Merged
Bento007
pushed a commit
that referenced
this pull request
May 17, 2022
* Remove unused build steps and comments * Remove gitignore * Remove more stuff * remove more GHA workflows
|
Should we also remove or rename the |
|
The EB AWS resource hasn't been destroyed. Is that future work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
@MDunitz
Readability:
Changes