Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up documentation and fix broken links. #252

Merged
merged 6 commits into from
May 13, 2022

Conversation

maniarathi
Copy link
Contributor

Reviewers

Functional: @MDunitz


Changes

Deletions

  • Removed Zenodo badge (only relevant for cellxgene Desktop).
  • Remove broken links that 404'd.

Modifications

  • Updated links that were pointing to the cellxgene Desktop to direct to files in this repo.
  • Updated links that were pointing to the old docs site to the new one.

@maniarathi maniarathi requested a review from MDunitz May 6, 2022 20:46
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #252 (8a273e6) into main (25070e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   76.12%   76.12%           
=======================================
  Files          90       90           
  Lines        6660     6660           
=======================================
  Hits         5070     5070           
  Misses       1590     1590           
Flag Coverage Δ
frontend 76.12% <ø> (ø)
javascript 76.12% <ø> (ø)
smokeTest ?
unitTest 76.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25070e1...8a273e6. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the links doesnt work for me and I added a small nit around phrasing.

maniarathi and others added 2 commits May 9, 2022 22:05
Co-authored-by: Madison Dunitz <madison.dunitz@chanzuckerberg.com>
@maniarathi maniarathi requested a review from MDunitz May 10, 2022 02:08
Copy link
Contributor

@MDunitz MDunitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@ebezzi ebezzi enabled auto-merge (squash) May 13, 2022 19:45
@ebezzi ebezzi merged commit f6c32b4 into main May 13, 2022
@ebezzi ebezzi deleted the maniarathi/doc_updates branch May 13, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants