chore: replaced deprecated method to open TileDB array (#56) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 76.49% 76.47% -0.03%
==========================================
Files 92 92
Lines 6764 6758 -6
==========================================
- Hits 5174 5168 -6
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bkmartinjr
reviewed
Mar 21, 2022
server/dataset/cxg_dataset.py
Outdated
| @@ -187,7 +187,7 @@ def _validate_and_initialize(self): | |||
|
|
|||
| @staticmethod | |||
| def _open_array(uri, tiledb_ctx): | |||
| with tiledb.Array(uri, mode="r", ctx=tiledb_ctx) as array: | |||
| with tiledb.open(uri, mode="r", ctx=tiledb_ctx) as array: | |||
There was a problem hiding this comment.
Reading this more closely, can't this entire function be replaced with a single call to tiledb.open?
Ie, return tiledb.open(uri, mode="r", ctx=tiledb_ctx)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
Functional:
Readability:
Changes
tiledb.Array()withtiledb.open()