chore: Upgrade to BlueprintJS 5 - SCE-4 (#1068)

.infra/rdev/values.yaml

@@ -2,7 +2,7 @@ stack:
   services:
     explorer:
       image:
-        tag: sha-517004d0
+        tag: sha-c96bbaf8
       replicaCount: 1
       env:
         # env vars common to all deployment stages

client/__tests__/e2e/cell-guide.test.ts

@@ -2,7 +2,7 @@
  * Smoke test suite that will be run in GHA
  * Tests included in this file are expected to be relatively stable and test core features
  *
- * (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp3 elements which route clicks to non-target elements
+ * (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp5 elements which route clicks to non-target elements
  *          https://playwright.dev/docs/input#forcing-the-click
  */
 

client/__tests__/e2e/cellxgeneActions.ts

@@ -862,43 +862,8 @@ export async function selectLayout(
   if (graphTsetId === sidePanel) {
     layoutChoiceTestId = `${LAYOUT_CHOICE_TEST_ID}-side`;
   }
-
   await page.getByTestId(layoutChoiceTestId).click({ force: true });
-
-  /**
-   * (thuang): For blueprint radio buttons, we need to tab first to go to the
-   * currently selected option before we can use the arrow keys to navigate
-   */
-  await page.keyboard.press("Tab");
-
-  const layoutChoices = await await page
-    .getByTestId(RegExp(`^${LAYOUT_CHOICE_TEST_ID}-label-`))
-    .allInnerTexts();
-
-  const currentlySelectedLayout = await page
-    .locator("label")
-    .filter({ has: page.getByRole("radio", { checked: true }) })
-    .innerText();
-
-  const currentIndex = layoutChoices.indexOf(currentlySelectedLayout);
-  const targetIndex = layoutChoices.findIndex((choice) =>
-    choice.includes(layoutChoice)
-  );
-
-  const relativePosition = targetIndex - currentIndex;
-
-  if (relativePosition > 0) {
-    // press down arrow N times
-    for (let i = 0; i < relativePosition; i += 1) {
-      await page.keyboard.press("ArrowDown");
-    }
-  } else {
-    // press up arrow N times
-    for (let i = 0; i < Math.abs(relativePosition); i += 1) {
-      await page.keyboard.press("ArrowUp");
-    }
-  }
-
+  await page.getByTestId(`layout-choice-label-${layoutChoice}`).click();
   await page.getByTestId(layoutChoiceTestId).click({ force: true });
 
   await page.waitForTimeout(WAIT_FOR_SWITCH_LAYOUT_MS);

client/__tests__/e2e/e2e.test.ts

@@ -2,7 +2,7 @@
  * Smoke test suite that will be run in GHA
  * Tests included in this file are expected to be relatively stable and test core features
  *
- * (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp3 elements which route clicks to non-target elements
+ * (seve): `locator.click({force: true})` is required on some elements due to weirdness with bp5 elements which route clicks to non-target elements
  *          https://playwright.dev/docs/input#forcing-the-click
  */