test: Make test more robust (#1049)

chanzuckerberg · Jul 22, 2024 · c977612 · c977612
1 parent 2125709
commit c977612
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.infra/rdev/values.yaml b/.infra/rdev/values.yaml
@@ -2,7 +2,7 @@ stack:
   services:
     explorer:
       image:
-        tag: sha-174a2b45
+        tag: sha-c765d258
       replicaCount: 1
       env:
         # env vars common to all deployment stages

diff --git a/client/__tests__/e2e/e2e.test.ts b/client/__tests__/e2e/e2e.test.ts
@@ -1524,7 +1524,16 @@ for (const testDataset of testDatasets) {
 
             await page.getByTestId("download-graph-button").click();
 
-            expect(downloads.length).toBe(2);
+            /**
+             * (thuang): Sometimes in GHA there's only 1 download, so we need to retry
+             * until we get 2 downloads
+             */
+            await tryUntil(
+              () => {
+                expect(downloads.length).toBe(2);
+              },
+              { page }
+            );
 
             const afterMinimizeDownloads: Download[] = [];