Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: mirror-data-to-staging-on-deploy #6044

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

atolopko-czi
Copy link
Contributor

  • run mirroring on staging deploy
  • temporarily disable real deploys during testing

Reason for Change

  • #TICKET_NUMBER
  • If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

  • add
  • remove
  • modify

Testing steps

  • Either list QA steps or reasoning you feel QA is unnecessary
  • Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
  • "Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Notes for Reviewer

@github-actions
Copy link
Contributor

Deployment Summary

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #6044 (6b9b5d1) into main (71d0c23) will increase coverage by 5.04%.
Report is 34 commits behind head on main.
The diff coverage is n/a.

❗ Current head 6b9b5d1 differs from pull request most recent head 8835cc7. Consider uploading reports for the commit 8835cc7 to get more accurate results

@@            Coverage Diff             @@
##             main    #6044      +/-   ##
==========================================
+ Coverage   85.84%   90.89%   +5.04%     
==========================================
  Files         196      169      -27     
  Lines       15410    13834    -1576     
==========================================
- Hits        13229    12574     -655     
+ Misses       2181     1260     -921     
Flag Coverage Δ
unittests 90.89% <ø> (+5.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 74 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

The existing scripts are not usable without major changes, due to differences
in how IAM roles are assumed in local usage vs GHA usage.
Copy link
Contributor

@prathapsridharan prathapsridharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  1. To be extra safe, might it be worthwhile to take a manual backup of prod data before running this?
  2. And maybe even have a script ready to update prod with the backup in case something does go wrong? (maybe this is over-cautious)

@atolopko-czi
Copy link
Contributor Author

Looks good!

  1. To be extra safe, might it be worthwhile to take a manual backup of prod data before running this?
  2. And maybe even have a script ready to update prod with the backup in case something does go wrong? (maybe this is over-cautious)

I'l do 1 for sure, and I'll create an RDS snapshot as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants