feat: allow ability to add global dependencies #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rzlim08
commented
Oct 3, 2024
rzlim08
commented
- Allows ability to add global dependencies to web app
jgadling
reviewed
Oct 4, 2024
| @@ -50,7 +50,7 @@ def get_graphql_name(self, obj: HasGraphQLName) -> str: | |||
| return super().get_graphql_name(obj) | |||
|
|
|||
|
|
|||
| def get_app(settings: APISettings, schema: strawberry.Schema, db_module: typing.Any) -> FastAPI: | |||
| def get_app(settings: APISettings, schema: strawberry.Schema, db_module: typing.Any, dependencies: typing.Optional[typing.Sequence[Depends]] = []) -> FastAPI: | |||
There was a problem hiding this comment.
Just out of curiosity, what are these global dependencies? Would they be any better represented as middlewares?
There was a problem hiding this comment.
basically to check auth tokens. I first wrote this as middleware but it was suggested to me that a dependency might be for that.
jgadling
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.