-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Variablize deletion_protection for aurora-postgres module #385
Conversation
@@ -136,3 +136,8 @@ variable "auto_minor_version_upgrade" { | |||
description = "Set the databases to automatically upgrade minor versions. WARNING - if this is enabled, make sure engine_version is set to a *prefix* rather that a specific version so that TF won't try to downgrade DB's that have been auto-upgraded. Docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version" | |||
default = false | |||
} | |||
|
|||
variable "db_deletion_protection" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶db_deletion_protection
variable has no description
@@ -136,3 +136,8 @@ variable "auto_minor_version_upgrade" { | |||
description = "Set the databases to automatically upgrade minor versions. WARNING - if this is enabled, make sure engine_version is set to a *prefix* rather that a specific version so that TF won't try to downgrade DB's that have been auto-upgraded. Docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version" | |||
default = false | |||
} | |||
|
|||
variable "db_deletion_protection" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable "db_deletion_protection" is declared but not used
Summary
Adding deletion_protection as a variable. Before, this defaulted to false because the
aws-aurora
module defaulted this variable to false.Test Plan
Say unittests, or list out steps to verify changes.
References
(Optional) Additional links to provide more context.