feat: Variablize deletion_protection for aurora-postgres module #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cziie
reviewed
May 13, 2022
| @@ -136,3 +136,8 @@ variable "auto_minor_version_upgrade" { | |||
| description = "Set the databases to automatically upgrade minor versions. WARNING - if this is enabled, make sure engine_version is set to a *prefix* rather that a specific version so that TF won't try to downgrade DB's that have been auto-upgraded. Docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version" | |||
| default = false | |||
| } | |||
|
|
|||
| variable "db_deletion_protection" { | |||
There was a problem hiding this comment.
📝 [tflint] reported by reviewdog 🐶db_deletion_protection variable has no description
| @@ -136,3 +136,8 @@ variable "auto_minor_version_upgrade" { | |||
| description = "Set the databases to automatically upgrade minor versions. WARNING - if this is enabled, make sure engine_version is set to a *prefix* rather that a specific version so that TF won't try to downgrade DB's that have been auto-upgraded. Docs: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#engine_version" | |||
| default = false | |||
| } | |||
|
|
|||
| variable "db_deletion_protection" { | |||
There was a problem hiding this comment.
variable "db_deletion_protection" is declared but not used
alexlokshin-czi
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding deletion_protection as a variable. Before, this defaulted to false because the
aws-auroramodule defaulted this variable to false.Test Plan
Say unittests, or list out steps to verify changes.
References
(Optional) Additional links to provide more context.