[feature] aws-s3-public-bucket require https, allow disabling versioning #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ability to disable versioning by default on public S3 buckets. Leaves default behavior of enabling versioning intact * Require TLS for every action
ryanking
previously approved these changes
Jan 12, 2021
ryanking
previously requested changes
Jan 12, 2021
|
This is a separate module from aws-single-page-static-site. In the only context it is used in CZI's code base, this has been working fine. |
mbarrien
force-pushed
the
mbarrien/public-bucket-https-versioning
branch
from
f2d9377
to
fb1df38
Compare
mbarrien
force-pushed
the
mbarrien/public-bucket-https-versioning
branch
from
fb1df38
to
70000e3
Compare
mbarrien
changed the title
|
Made TLS optional via another variable. Please re-review. |
kuannie1
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds functionality from CZI's private version of this module.
Leaves default behavior of enabling versioning intact